Skip to content

Remove unnecessary dependencies at useCallcak#393

Closed
hahnlee wants to merge 2 commits intotwilio:masterfrom
hahnlee:fix/deps
Closed

Remove unnecessary dependencies at useCallcak#393
hahnlee wants to merge 2 commits intotwilio:masterfrom
hahnlee:fix/deps

Conversation

@hahnlee
Copy link
Copy Markdown
Contributor

@hahnlee hahnlee commented Dec 28, 2020

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

Description

Remove unnecessary dependencies at useCallcak

Burndown

Before review

  • Verified locally with npm test
  • Manually sanity tested running locally
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza
Copy link
Copy Markdown
Contributor

Hi @hahnlee - thanks for the pull request!

I think the PR looks good, but unfortunately I can't merge it because our CircleCI tests aren't allowed to run on third-party pull requests due to security concerns. I created a new PR here that contains your commit, so when I merge it you'll still be listed as a contributor.

I'll close this PR and merge #527 in instead.

Thanks!

@timmydoza timmydoza closed this May 24, 2021
@timmydoza timmydoza mentioned this pull request May 24, 2021
10 tasks
@hahnlee hahnlee deleted the fix/deps branch May 25, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants